diff -ruBbd cacti-0.8.6j/auth_login.php cacti-0.8.6j-patched/auth_login.php --- cacti-0.8.6j/auth_login.php 2007-01-17 19:23:10.000000000 -0500 +++ cacti-0.8.6j-patched/auth_login.php 2008-02-11 20:28:31.000000000 -0500 @@ -29,20 +27,23 @@ switch ($_REQUEST["action"]) { case 'login': + + $username = sanitize_search_string(get_request_var_post('login_username')); + /* --- start ldap section --- */ $ldap_auth = false; - if ((read_config_option("ldap_enabled") == "on") && ($_POST["realm"] == "ldap") && (strlen($_POST["login_password"])) && (strlen($_POST["login_username"]))){ + if ((read_config_option("ldap_enabled") == "on") && ($_POST["realm"] == "ldap") && (strlen($username)) && (strlen($username))){ $ldap_conn = ldap_connect(read_config_option("ldap_server")); if ($ldap_conn) { - $ldap_dn = str_replace("",$_POST["login_username"],read_config_option("ldap_dn")); + $ldap_dn = str_replace("",$username,read_config_option("ldap_dn")); $ldap_response = @ldap_bind($ldap_conn,$ldap_dn,stripslashes($_POST["login_password"])); if ($ldap_response) { $ldap_auth = true; - if (sizeof(db_fetch_assoc("select * from user_auth where username='" . $_POST["login_username"] . "' and realm = 1")) == 0) { + if (sizeof(db_fetch_assoc("select * from user_auth where username='$username' and realm = 1")) == 0) { /* copy template user's settings */ - user_copy(read_config_option("ldap_template"), $_POST["login_username"], 1); + user_copy(read_config_option("ldap_template"), $username, 1); } } } @@ -50,14 +51,14 @@ /* --- end ldap section --- */ if ($ldap_auth) { - $user = db_fetch_row("select * from user_auth where username='" . $_POST["login_username"] . "' and realm = 1"); + $user = db_fetch_row("select * from user_auth where username='$username' and realm = 1"); } else { - $user = db_fetch_row("select * from user_auth where username='" . $_POST["login_username"] . "' and password = '" . md5($_POST["login_password"]) . "' and realm = 0"); + $user = db_fetch_row("select * from user_auth where username='$username' and password = '" . md5($_POST["login_password"]) . "' and realm = 0"); } if (sizeof($user)) { /* make entry in the transactions log */ - db_execute("insert into user_log (username,user_id,result,ip,time) values('" . $_POST["login_username"] ."'," . $user["id"] . ",1,'" . $_SERVER["REMOTE_ADDR"] . "',NOW())"); + db_execute("insert into user_log (username,user_id,result,ip,time) values('$username'," . $user["id"] . ",1,'" . $_SERVER["REMOTE_ADDR"] . "',NOW())"); /* set the php session */ $_SESSION["sess_user_id"] = $user["id"]; @@ -86,7 +87,7 @@ exit; }else{ /* --- BAD username/password --- */ - db_execute("insert into user_log (username,user_id,result,ip,time) values('" . $_POST["login_username"] . "',0,0,'" . $_SERVER["REMOTE_ADDR"] . "',NOW())"); + db_execute("insert into user_log (username,user_id,result,ip,time) values('$username',0,0,'" . $_SERVER["REMOTE_ADDR"] . "',NOW())"); } } diff -ruBbd cacti-0.8.6j/graph.php cacti-0.8.6j-patched/graph.php --- cacti-0.8.6j/graph.php 2007-01-17 19:23:10.000000000 -0500 +++ cacti-0.8.6j-patched/graph.php 2008-02-11 20:28:31.000000000 -0500 @@ -35,10 +33,15 @@ include("./include/top_graph_header.php"); /* ================= input validation ================= */ -input_validate_input_regex(get_request_var("rra_id"), "^([0-9]+|all)$"); +input_validate_input_regex(get_request_var_request("rra_id"), "^([0-9]+|all)$"); input_validate_input_number(get_request_var("local_graph_id")); +input_validate_input_regex(get_request_var_request("view_type"), "^([a-zA-Z0-9]+)$"); /* ==================================================== */ +if (!isset($_GET['rra_id'])) { + $_GET['rra_id'] = 'all'; +} + if ($_GET["rra_id"] == "all") { $sql_where = " where id is not null"; }else{ diff -ruBbd cacti-0.8.6j/graph_view.php cacti-0.8.6j-patched/graph_view.php --- cacti-0.8.6j/graph_view.php 2007-01-17 19:23:10.000000000 -0500 +++ cacti-0.8.6j-patched/graph_view.php 2008-02-11 20:28:31.000000000 -0500 @@ -36,6 +34,9 @@ input_validate_input_number(get_request_var("tree_id")); input_validate_input_number(get_request_var("leaf_id")); input_validate_input_number(get_request_var("rra_id")); +input_validate_input_regex(get_request_var_request('graph_list'), "^([\,0-9]+)$"); +input_validate_input_regex(get_request_var_request('graph_add'), "^([\,0-9]+)$"); +input_validate_input_regex(get_request_var_request('graph_remove'), "^([\,0-9]+)$"); /* ==================================================== */ if (isset($_GET["hide"])) { @@ -387,7 +388,7 @@