https://github.com/scop/bash-completion/issues/1317 https://github.com/scop/bash-completion/commit/af8a80d8916edd4a1c146afb2743651b6c3ca406 From af8a80d8916edd4a1c146afb2743651b6c3ca406 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ville=20Skytt=C3=A4?= Date: Tue, 21 Jan 2025 23:54:41 +0200 Subject: [PATCH] refactor(secret-tool): deprecate ours in favor of upstream Closes https://github.com/scop/bash-completion/issues/1317 --- completions/Makefile.am | 2 +- completions/{secret-tool => _secret-tool} | 3 +++ test/fallback/completions/Makefile.am | 1 + test/fallback/completions/secret-tool | 1 + 4 files changed, 6 insertions(+), 1 deletion(-) rename completions/{secret-tool => _secret-tool} (93%) create mode 120000 test/fallback/completions/secret-tool diff --git a/completions/Makefile.am b/completions/Makefile.am index 899bec5259d..21b6f9e49f0 100644 --- a/completions/Makefile.am +++ b/completions/Makefile.am @@ -398,7 +398,7 @@ cross_platform = 2to3 \ sbopkg \ screen \ scrub \ - secret-tool \ + _secret-tool \ set \ sh \ sha256sum \ diff --git a/completions/secret-tool b/completions/_secret-tool similarity index 93% rename from completions/secret-tool rename to completions/_secret-tool index e8aafd81aef..862bfa8c73d 100644 --- a/completions/secret-tool +++ b/completions/_secret-tool @@ -1,5 +1,8 @@ # bash completion for secret-tool(1) -*- shell-script -*- +# Use of this file is deprecated. Upstream completion is available in +# libsecret >= 0.20.5, use that instead. + _comp_cmd_secret_tool() { local cur prev words cword was_split comp_args diff --git a/test/fallback/completions/Makefile.am b/test/fallback/completions/Makefile.am index 28358b4e7d6..24e9c9755ff 100644 --- a/test/fallback/completions/Makefile.am +++ b/test/fallback/completions/Makefile.am @@ -46,6 +46,7 @@ EXTRA_DIST = \ ruff \ runuser \ rustup \ + secret-tool \ slackpkg \ sops \ stern \ diff --git a/test/fallback/completions/secret-tool b/test/fallback/completions/secret-tool new file mode 120000 index 00000000000..ab0a8361057 --- /dev/null +++ b/test/fallback/completions/secret-tool @@ -0,0 +1 @@ +../../../completions/_secret-tool \ No newline at end of file